Skip to content

use Rust 2-1-trixie base and OPAM 2.5.0 #8199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
tsnobip merged 6 commits into from
Jan 20, 2026
Merged

use Rust 2-1-trixie base and OPAM 2.5.0 #8199

tsnobip merged 6 commits into from
Jan 20, 2026
+16 −4

Conversation

@tsnobip
Copy link
Member

@tsnobip tsnobip commented Jan 20, 2026

No description provided.

@nojaf
Copy link
Member

nojaf commented Jan 20, 2026

@tsnobip are we building this dev container during CI?
Or do we run a build of rescript inside the container during CI?

@cknitt
Copy link
Member

cknitt commented Jan 20, 2026

Ae we building this dev container during CI? Or do we run a build of rescript inside the container during CI?

Neither. This is only for usage in VS Code: https://code.visualstudio.com/docs/devcontainers/containers

@pkg-pr-new
Copy link

pkg-pr-new bot commented Jan 20, 2026 •
edited
Loading

Open in StackBlitz

rescript

npm i https://pkg.pr.new/rescript-lang/rescript@8199

@rescript/darwin-arm64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/darwin-arm64@8199

@rescript/darwin-x64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/darwin-x64@8199

@rescript/linux-arm64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/linux-arm64@8199

@rescript/linux-x64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/linux-x64@8199

@rescript/runtime

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/runtime@8199

@rescript/win32-x64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/win32-x64@8199

commit: bc32032

@nojaf
Copy link
Member

nojaf commented Jan 20, 2026

We probably should run make in the devcontainer during CI.

Add a job that uses https://github.com/devcontainers/ci and run some of the make commands.
This ensures the container remains usable over time.

@tsnobip tsnobip force-pushed the devcontainer-update-rust-opam branch from 9ea8f6c to 54ac5cc Compare January 20, 2026 10:29
@tsnobip
Copy link
Member Author

tsnobip commented Jan 20, 2026

@nojaf there's now a test that checks that you can run make from the devcontainer.

nojaf
nojaf approved these changes Jan 20, 2026
View reviewed changes
Copy link
Member

@nojaf nojaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @tsnobip !

@tsnobip tsnobip merged commit 20b0760 into master Jan 20, 2026
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nojaf nojaf nojaf approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@tsnobip @nojaf @cknitt